From 3881fff26f5ef2cfe8926b288cf994232c59f9e4 Mon Sep 17 00:00:00 2001
From: Robert Goldmann <deadlocker@gmx.de>
Date: Wed, 10 Feb 2021 17:25:45 +0100
Subject: [PATCH] SensorLineChartTile: Fixed error when generating ghost trace
if there is no data available
---
src/logic/tile/tiles/SensorLineChartTile.py | 3 +++
test/logic/tile/tiles/TestSensorLineChartTile.py | 6 ++++++
2 files changed, 9 insertions(+)
diff --git a/src/logic/tile/tiles/SensorLineChartTile.py b/src/logic/tile/tiles/SensorLineChartTile.py
index 1e83e71..48e3005 100644
--- a/src/logic/tile/tiles/SensorLineChartTile.py
+++ b/src/logic/tile/tiles/SensorLineChartTile.py
@@ -152,6 +152,9 @@ class SensorLineChartTile(Tile):
ghostTraceX = []
ghostTraceY = []
+ if not x or not y:
+ return ghostTraceX, ghostTraceY
+
if all(float(i) >= 0 for i in y):
if minValue < 0:
ghostTraceX = [x[0], x[-1]]
diff --git a/test/logic/tile/tiles/TestSensorLineChartTile.py b/test/logic/tile/tiles/TestSensorLineChartTile.py
index 065fa6f..abe0caf 100644
--- a/test/logic/tile/tiles/TestSensorLineChartTile.py
+++ b/test/logic/tile/tiles/TestSensorLineChartTile.py
@@ -162,3 +162,9 @@ class TestPrepareGhostTrace:
x = ['2021-02-09 17:47:55', '2021-02-09 17:48:55']
y = [6, 8]
assert tile._prepare_ghost_trace(-10, x, y) == (x, [-10, -10])
+
+ def test_no_values_returns_empty_lists(self):
+ tile = SensorLineChartTile('mySensorTile', example_settings(False), 10)
+ x = []
+ y = []
+ assert tile._prepare_ghost_trace(-10, x, y) == ([], [])
--
GitLab