From 5b96e56138be121c1ae50dd8dd8c67ce6c10b9cc Mon Sep 17 00:00:00 2001
From: Robert Goldmann <deadlocker@gmx.de>
Date: Sun, 11 Apr 2021 11:13:49 +0200
Subject: [PATCH] Fixed #48 - GarbageContainerScheduleTile: notifications are
send multiple times per day
---
src/logic/tile/tiles/GarbageContainerScheduleTile.py | 1 -
.../tile/tiles/TestGarbageContainerScheduleTile.py | 11 +++++++++++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/src/logic/tile/tiles/GarbageContainerScheduleTile.py b/src/logic/tile/tiles/GarbageContainerScheduleTile.py
index 4a7ca89..10f7dc8 100644
--- a/src/logic/tile/tiles/GarbageContainerScheduleTile.py
+++ b/src/logic/tile/tiles/GarbageContainerScheduleTile.py
@@ -94,7 +94,6 @@ class GarbageContainerScheduleTile(Tile):
return
if self._is_already_notified(now):
- self._lastNotificationDate = None
return
self._lastNotificationDate = now.date()
diff --git a/test/logic/tile/tiles/TestGarbageContainerScheduleTile.py b/test/logic/tile/tiles/TestGarbageContainerScheduleTile.py
index 48821d8..20dff9b 100644
--- a/test/logic/tile/tiles/TestGarbageContainerScheduleTile.py
+++ b/test/logic/tile/tiles/TestGarbageContainerScheduleTile.py
@@ -85,3 +85,14 @@ class TestSendNotification:
tile._send_notification(1, '')
requestsMock.post.assert_called_once()
+
+ @mock.patch('logic.Helpers.requests')
+ def test_already_notified_should_skip_sending_even_if_already_skipped_before(self, requestsMock):
+ tile = GarbageContainerScheduleTile('myGarbageScheduleTile', example_settings(True), 10)
+
+ requestsMock.post.return_value.status_code = 200
+ tile._send_notification(1, '')
+ tile._send_notification(1, '')
+ tile._send_notification(1, '')
+
+ requestsMock.post.assert_called_once()
--
GitLab