From 8770567b0544ae3387c2f32ed53d96a35ee4c03f Mon Sep 17 00:00:00 2001
From: Robert Goldmann <deadlocker@gmx.de>
Date: Wed, 6 May 2020 19:24:13 +0200
Subject: [PATCH] BaseUtils: MailHandler: don't send mail multiple times if
multiple receivers are registered (v1.1.1)
---
.../TheCodeLabs_BaseUtils/MailHandler.py | 17 ++++++++---------
TheCodeLabs_BaseUtils/setup.py | 2 +-
2 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/TheCodeLabs_BaseUtils/TheCodeLabs_BaseUtils/MailHandler.py b/TheCodeLabs_BaseUtils/TheCodeLabs_BaseUtils/MailHandler.py
index b40471b..91f27a6 100644
--- a/TheCodeLabs_BaseUtils/TheCodeLabs_BaseUtils/MailHandler.py
+++ b/TheCodeLabs_BaseUtils/TheCodeLabs_BaseUtils/MailHandler.py
@@ -18,21 +18,20 @@ class MailHandler:
@staticmethod
def send(host: str, port: int, userName: str, password: str, receiverMails: List[str], subject: str, content: str):
- for receiver in receiverMails:
- message = MailHandler.__create_message(userName, receiver, subject, content)
+ message = MailHandler.__create_message(userName, receiverMails, subject, content)
- # Create secure connection with server and send email
- context = ssl.create_default_context()
- with smtplib.SMTP_SSL(host, port, context=context) as server:
- server.login(userName, password)
- server.sendmail(userName, receiverMails, message.as_string())
+ # Create secure connection with server and send email
+ context = ssl.create_default_context()
+ with smtplib.SMTP_SSL(host, port, context=context) as server:
+ server.login(userName, password)
+ server.sendmail(userName, receiverMails, message.as_string())
@staticmethod
- def __create_message(userName: str, receiver: str, subject: str, content: str) -> MIMEMultipart:
+ def __create_message(userName: str, receiverMails: List[str], subject: str, content: str) -> MIMEMultipart:
message = MIMEMultipart('alternative')
message['Subject'] = subject
message['From'] = userName
- message['To'] = receiver
+ message['To'] = ', '.join(receiverMails)
# Create the plain-text and HTML version of your message
text = subject
diff --git a/TheCodeLabs_BaseUtils/setup.py b/TheCodeLabs_BaseUtils/setup.py
index 3795e7e..5c8a52c 100644
--- a/TheCodeLabs_BaseUtils/setup.py
+++ b/TheCodeLabs_BaseUtils/setup.py
@@ -3,7 +3,7 @@ from setuptools import setup
setup(
name='TheCodeLabs-BaseUtils',
packages=['TheCodeLabs_BaseUtils'],
- version='1.1.0',
+ version='1.1.1',
license='MIT',
description='Useful python classes',
author='TheCodeLabs',
--
GitLab