From 0e393ac11cdfcbddfd83ca753d656ec80afb04bb Mon Sep 17 00:00:00 2001
From: Robert Goldmann <deadlocker@gmx.de>
Date: Wed, 9 Feb 2022 21:44:39 +0100
Subject: [PATCH] Refactoring: supress warnings

---
 .../budgetmaster/database/model/v4/BackupDatabase_v4.java  | 6 ++++--
 .../budgetmaster/database/model/v5/BackupDatabase_v5.java  | 6 ++++--
 .../budgetmaster/database/model/v6/BackupDatabase_v6.java  | 7 ++++---
 .../budgetmaster/database/model/v7/BackupDatabase_v7.java  | 6 ++++--
 .../budgetmaster/database/model/v8/BackupDatabase_v8.java  | 6 ++++--
 5 files changed, 20 insertions(+), 11 deletions(-)

diff --git a/src/main/java/de/deadlocker8/budgetmaster/database/model/v4/BackupDatabase_v4.java b/src/main/java/de/deadlocker8/budgetmaster/database/model/v4/BackupDatabase_v4.java
index 096d4a512..092e92280 100644
--- a/src/main/java/de/deadlocker8/budgetmaster/database/model/v4/BackupDatabase_v4.java
+++ b/src/main/java/de/deadlocker8/budgetmaster/database/model/v4/BackupDatabase_v4.java
@@ -13,10 +13,12 @@ public class BackupDatabase_v4 implements BackupDatabase
 	@SuppressWarnings("unused")
 	private final String TYPE = JSONIdentifier.BUDGETMASTER_DATABASE.toString();
 
-	@SuppressWarnings("FieldCanBeLocal")
+	@SuppressWarnings({"FieldCanBeLocal", "squid:S1170"})
+	// field can not be static, since static field won't be exported to JSON by GSON
 	private final int VERSION = 4;
 
-	@SuppressWarnings("unused")
+	@SuppressWarnings({"unused", "squid:S2065", "squid:S1170"})
+	// field can not be static, since static field won't be exported to JSON by GSON
 	private final transient String INTRODUCED_IN_VERSION = "v2.5.0";
 
 	private List<BackupCategory_v4> categories;
diff --git a/src/main/java/de/deadlocker8/budgetmaster/database/model/v5/BackupDatabase_v5.java b/src/main/java/de/deadlocker8/budgetmaster/database/model/v5/BackupDatabase_v5.java
index 1a7b3f666..c392a01d8 100644
--- a/src/main/java/de/deadlocker8/budgetmaster/database/model/v5/BackupDatabase_v5.java
+++ b/src/main/java/de/deadlocker8/budgetmaster/database/model/v5/BackupDatabase_v5.java
@@ -12,10 +12,12 @@ public class BackupDatabase_v5 implements BackupDatabase
 	@SuppressWarnings("unused")
 	private final String TYPE = JSONIdentifier.BUDGETMASTER_DATABASE.toString();
 
-	@SuppressWarnings("FieldCanBeLocal")
+	@SuppressWarnings({"FieldCanBeLocal", "squid:S1170"})
+	// field can not be static, since static field won't be exported to JSON by GSON
 	private final int VERSION = 5;
 
-	@SuppressWarnings("unused")
+	@SuppressWarnings({"unused", "squid:S2065", "squid:S1170"})
+	// field can not be static, since static field won't be exported to JSON by GSON
 	private final transient String INTRODUCED_IN_VERSION = "v2.6.0";
 
 	private List<BackupCategory_v5> categories;
diff --git a/src/main/java/de/deadlocker8/budgetmaster/database/model/v6/BackupDatabase_v6.java b/src/main/java/de/deadlocker8/budgetmaster/database/model/v6/BackupDatabase_v6.java
index 482bcc2d6..fd13ef42a 100644
--- a/src/main/java/de/deadlocker8/budgetmaster/database/model/v6/BackupDatabase_v6.java
+++ b/src/main/java/de/deadlocker8/budgetmaster/database/model/v6/BackupDatabase_v6.java
@@ -12,17 +12,18 @@ import de.deadlocker8.budgetmaster.database.model.v7.BackupIcon_v7;
 
 import java.util.ArrayList;
 import java.util.List;
-import java.util.stream.Collectors;
 
 public class BackupDatabase_v6 implements BackupDatabase
 {
 	@SuppressWarnings("unused")
 	private final String TYPE = JSONIdentifier.BUDGETMASTER_DATABASE.toString();
 
-	@SuppressWarnings("FieldCanBeLocal")
+	@SuppressWarnings({"FieldCanBeLocal", "squid:S1170"})
+	// field can not be static, since static field won't be exported to JSON by GSON
 	private final int VERSION = 6;
 
-	@SuppressWarnings("unused")
+	@SuppressWarnings({"unused", "squid:S2065", "squid:S1170"})
+	// field can not be static, since static field won't be exported to JSON by GSON
 	private final transient String INTRODUCED_IN_VERSION = "v2.7.0";
 
 	private List<BackupCategory_v5> categories;
diff --git a/src/main/java/de/deadlocker8/budgetmaster/database/model/v7/BackupDatabase_v7.java b/src/main/java/de/deadlocker8/budgetmaster/database/model/v7/BackupDatabase_v7.java
index f86d8f068..f288c8df7 100644
--- a/src/main/java/de/deadlocker8/budgetmaster/database/model/v7/BackupDatabase_v7.java
+++ b/src/main/java/de/deadlocker8/budgetmaster/database/model/v7/BackupDatabase_v7.java
@@ -15,10 +15,12 @@ public class BackupDatabase_v7 implements BackupDatabase
 	@SuppressWarnings("unused")
 	private final String TYPE = JSONIdentifier.BUDGETMASTER_DATABASE.toString();
 
-	@SuppressWarnings("FieldCanBeLocal")
+	@SuppressWarnings({"FieldCanBeLocal", "squid:S1170"})
+	// field can not be static, since static field won't be exported to JSON by GSON
 	private final int VERSION = 7;
 
-	@SuppressWarnings("unused")
+	@SuppressWarnings({"unused", "squid:S2065", "squid:S1170"})
+	// field can not be static, since static field won't be exported to JSON by GSON
 	private final transient String INTRODUCED_IN_VERSION = "v2.8.0";
 
 	private List<BackupCategory_v7> categories;
diff --git a/src/main/java/de/deadlocker8/budgetmaster/database/model/v8/BackupDatabase_v8.java b/src/main/java/de/deadlocker8/budgetmaster/database/model/v8/BackupDatabase_v8.java
index e1d78144e..6625e9343 100644
--- a/src/main/java/de/deadlocker8/budgetmaster/database/model/v8/BackupDatabase_v8.java
+++ b/src/main/java/de/deadlocker8/budgetmaster/database/model/v8/BackupDatabase_v8.java
@@ -25,10 +25,12 @@ public class BackupDatabase_v8 implements BackupDatabase
 	@SuppressWarnings("unused")
 	private final String TYPE = JSONIdentifier.BUDGETMASTER_DATABASE.toString();
 
-	@SuppressWarnings("FieldCanBeLocal")
+	@SuppressWarnings({"FieldCanBeLocal", "squid:S1170"})
+	// field can not be static, since static field won't be exported to JSON by GSON
 	private final int VERSION = 8;
 
-	@SuppressWarnings("unused")
+	@SuppressWarnings({"unused", "squid:S2065", "squid:S1170"})
+	// field can not be static, since static field won't be exported to JSON by GSON
 	private final transient String INTRODUCED_IN_VERSION = "v2.9.0";
 
 	private List<BackupCategory_v7> categories;
-- 
GitLab