From 395753a4d79326934d231c3bfc71c51f21b0c8af Mon Sep 17 00:00:00 2001
From: Robert Goldmann <deadlocker@gmx.de>
Date: Sun, 25 Jul 2021 12:19:15 +0200
Subject: [PATCH] #585 - set hidden inputs only if chart is selected

---
 src/main/resources/static/js/charts.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/resources/static/js/charts.js b/src/main/resources/static/js/charts.js
index 3c0fae50e..ba94c935e 100644
--- a/src/main/resources/static/js/charts.js
+++ b/src/main/resources/static/js/charts.js
@@ -80,7 +80,6 @@ $(document).ready(function()
     $('.button-display-type').click(function()
     {
         toggleChartTypeButtons('button-display-type', this);
-        document.getElementsByName('displayType')[0].value = this.dataset.value;
         hideGroupTypeButtonsIfOnlyOneDistinctGroup();
         filterChartPreviews();
     });
@@ -88,7 +87,6 @@ $(document).ready(function()
     $('.button-group-type').click(function()
     {
         toggleChartTypeButtons('button-group-type', this);
-        document.getElementsByName('groupType')[0].value = this.dataset.value;
         filterChartPreviews();
     });
 
@@ -97,6 +95,8 @@ $(document).ready(function()
         unsetActiveChartPreview();
 
         this.querySelector('.chart-preview').classList.toggle('active', true);
+        document.getElementsByName('displayType')[0].value = this.dataset.displayType;
+        document.getElementsByName('groupType')[0].value = this.dataset.groupType;
         document.getElementsByName('chartID')[0].value = this.dataset.id;
         checkShowChartButton();
     });
-- 
GitLab