From 413bb315859eae37bfdf849378516b2e66473f86 Mon Sep 17 00:00:00 2001
From: Robert Goldmann <deadlocker@gmx.de>
Date: Wed, 9 Feb 2022 21:20:26 +0100
Subject: [PATCH] Refactoring: fixed allowed http methods
---
.../budgetmaster/controller/AboutController.java | 2 +-
.../deadlocker8/budgetmaster/reports/ReportController.java | 7 ++-----
.../budgetmaster/settings/SettingsController.java | 2 +-
3 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/main/java/de/deadlocker8/budgetmaster/controller/AboutController.java b/src/main/java/de/deadlocker8/budgetmaster/controller/AboutController.java
index e9e68ba0c..e9a556f20 100644
--- a/src/main/java/de/deadlocker8/budgetmaster/controller/AboutController.java
+++ b/src/main/java/de/deadlocker8/budgetmaster/controller/AboutController.java
@@ -59,7 +59,7 @@ public class AboutController extends BaseController
return ReturnValues.WHATS_NEW;
}
- @RequestMapping("/whatsNewModal/close")
+ @GetMapping("/whatsNewModal/close")
@Transactional
public String whatsNewModalClose(HttpServletRequest request)
{
diff --git a/src/main/java/de/deadlocker8/budgetmaster/reports/ReportController.java b/src/main/java/de/deadlocker8/budgetmaster/reports/ReportController.java
index e109bff77..24c6823ca 100644
--- a/src/main/java/de/deadlocker8/budgetmaster/reports/ReportController.java
+++ b/src/main/java/de/deadlocker8/budgetmaster/reports/ReportController.java
@@ -21,10 +21,7 @@ import org.joda.time.DateTime;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Controller;
import org.springframework.ui.Model;
-import org.springframework.web.bind.annotation.CookieValue;
-import org.springframework.web.bind.annotation.ModelAttribute;
-import org.springframework.web.bind.annotation.PostMapping;
-import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.*;
import javax.servlet.ServletOutputStream;
import javax.servlet.http.HttpServletRequest;
@@ -72,7 +69,7 @@ public class ReportController extends BaseController
this.filterHelpers = filterHelpers;
}
- @RequestMapping
+ @GetMapping
public String reports(HttpServletRequest request, Model model, @CookieValue(value = "currentDate", required = false) String cookieDate)
{
DateTime date = dateService.getDateTimeFromCookie(cookieDate);
diff --git a/src/main/java/de/deadlocker8/budgetmaster/settings/SettingsController.java b/src/main/java/de/deadlocker8/budgetmaster/settings/SettingsController.java
index 4423ab262..55e2c70e3 100644
--- a/src/main/java/de/deadlocker8/budgetmaster/settings/SettingsController.java
+++ b/src/main/java/de/deadlocker8/budgetmaster/settings/SettingsController.java
@@ -321,7 +321,7 @@ public class SettingsController extends BaseController
return ReturnValues.ALL_ENTITIES;
}
- @RequestMapping("/database/upload")
+ @PostMapping("/database/upload")
public String upload(WebRequest request, Model model, @RequestParam("file") MultipartFile file)
{
if(file.isEmpty())
--
GitLab