From e519f4cc357e3c9f534ccb2ea107bfa919abf2ce Mon Sep 17 00:00:00 2001
From: Robert Goldmann <deadlocker@gmx.de>
Date: Sun, 8 Oct 2017 14:58:58 +0200
Subject: [PATCH] Fixed #216 - updater --> downloaded exe is not runnable

---
 .../budgetmaster/logic/updater/Updater.java           | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/BudgetMasterCore/src/main/java/de/deadlocker8/budgetmaster/logic/updater/Updater.java b/BudgetMasterCore/src/main/java/de/deadlocker8/budgetmaster/logic/updater/Updater.java
index 9b6fc1041..cfd054972 100644
--- a/BudgetMasterCore/src/main/java/de/deadlocker8/budgetmaster/logic/updater/Updater.java
+++ b/BudgetMasterCore/src/main/java/de/deadlocker8/budgetmaster/logic/updater/Updater.java
@@ -119,16 +119,11 @@ public class Updater
 	{
 		File currentExecutable = getCurrentExecutableName();
 		String currentFileName = currentExecutable.getName();
-		String fileEnding;
 		
 		//check if BudgetMaster is running from executable
 		//no updating procedure if running from source
-		if(currentFileName.contains("."))
-		{
-			fileEnding = currentExecutable.getAbsolutePath().substring(currentExecutable.getAbsolutePath().indexOf("."), currentExecutable.getAbsolutePath().length());			
-		}
-		else
-		{
+		if(!currentFileName.contains("."))
+		{			
 			Logger.debug("Update procedure will be skipped because BudgetMaster is running from source");
 			return;
 		}
@@ -141,7 +136,7 @@ public class Updater
 		
 		//download into temp directory and file
 		Path target;
-		if(fileEnding.equalsIgnoreCase("exe"))
+		if(currentFileName.endsWith(".exe"))
 		{			
 			target = Paths.get(PathUtils.getOSindependentPath() + Localization.getString(Strings.FOLDER) + "/update_BudgetMaster.exe");			
 			download(BUILD_FOLDER + "BudgetMaster.exe", target);			
-- 
GitLab