From f9cddec928901024e2fdea291e71470363eac5d4 Mon Sep 17 00:00:00 2001 From: Robert Goldmann <deadlocker@gmx.de> Date: Mon, 23 Nov 2020 20:01:27 +0100 Subject: [PATCH] stabilized integration tests: use id for saving account --- .../deadlocker8/budgetmaster/categories/CategoryController.java | 2 +- .../budgetmaster/integration/helpers/IntegrationTestHelper.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/de/deadlocker8/budgetmaster/categories/CategoryController.java b/src/main/java/de/deadlocker8/budgetmaster/categories/CategoryController.java index 98e7f0e49..93def3e53 100644 --- a/src/main/java/de/deadlocker8/budgetmaster/categories/CategoryController.java +++ b/src/main/java/de/deadlocker8/budgetmaster/categories/CategoryController.java @@ -90,7 +90,7 @@ public class CategoryController extends BaseController public String editCategory(Model model, @PathVariable("ID") Integer ID) { Optional<Category> categoryOptional = categoryService.findById(ID); - if(!categoryOptional.isPresent()) + if(categoryOptional.isEmpty()) { throw new ResourceNotFoundException(); } diff --git a/src/test/java/de/deadlocker8/budgetmaster/integration/helpers/IntegrationTestHelper.java b/src/test/java/de/deadlocker8/budgetmaster/integration/helpers/IntegrationTestHelper.java index fdf17be49..e4e885444 100644 --- a/src/test/java/de/deadlocker8/budgetmaster/integration/helpers/IntegrationTestHelper.java +++ b/src/test/java/de/deadlocker8/budgetmaster/integration/helpers/IntegrationTestHelper.java @@ -144,7 +144,7 @@ public class IntegrationTestHelper wait.until(ExpectedConditions.visibilityOfElementLocated(By.id("account-name"))); WebElement inputAccountName = driver.findElement(By.id("account-name")); inputAccountName.sendKeys(accountName); - driver.findElement(By.tagName("button")).click(); + driver.findElement(By.id("button-save-account")).click(); } private void matchAccounts(List<String> sourceAccounts, List<String> destinationAccounts) -- GitLab