#561 - income templates not prefilled correctly:

- pass new transaction object instead of template (avoids manipulation of the original template)

src/main/java/de/deadlocker8/budgetmaster/templates/TemplateController.java

@@ -116,10 +116,19 @@ public class TemplateController extends BaseController
 		}
 
 		final Template template = templateOptional.get();
-
-		templateService.prepareTemplateForNewTransaction(template, true);
-
-		if(template.getAmount() == null)
+		final Transaction newTransaction = new Transaction();
+		newTransaction.setName(template.getName());
+		newTransaction.setAmount(template.getAmount());
+		newTransaction.setCategory(template.getCategory());
+		newTransaction.setDescription(template.getDescription());
+		newTransaction.setAccount(template.getAccount());
+		newTransaction.setTransferAccount(template.getTransferAccount());
+		newTransaction.setTags(template.getTags());
+		newTransaction.setIsExpenditure(template.isExpenditure());
+
+		templateService.prepareTemplateForNewTransaction(newTransaction, true);
+
+		if(newTransaction.getAmount() == null && newTransaction.isExpenditure() == null)
 		{
 			template.setIsExpenditure(true);
 		}

src/main/java/de/deadlocker8/budgetmaster/templates/TemplateService.java

@@ -72,7 +72,7 @@ public class TemplateService implements Resetable
 		getRepository().save(template);
 	}
 
-	public void prepareTemplateForNewTransaction(Template template, boolean prepareAccount)
+	public void prepareTemplateForNewTransaction(TransactionBase template, boolean prepareAccount)
 	{
 		if(template.getCategory() == null)
 		{

src/main/java/de/deadlocker8/budgetmaster/transactions/TransactionBase.java

@@ -18,6 +18,8 @@ public interface TransactionBase
 
 	Category getCategory();
 
+	void setCategory(Category category);
+
 	List<Tag> getTags();
 
 	void setTags(List<Tag> tags);