#622 - show built-in icons as default tab

src/main/resources/templates/helpers/iconSelect.ftl

@@ -27,15 +27,15 @@
 
 
 <#macro modalIconSelect idToFocusOnClose item>
-    <#assign hasBuiltinIcon=item.getIconReference()?? && item.getIconReference().getBuiltinIdentifier()??/>
+    <#assign hasImageIcon=item.getIconReference()?? && item.getIconReference().getImage()??/>
 
     <div id="modalIconSelect" class="modal modal-fixed-footer background-color" data-focus-on-close="${idToFocusOnClose}">
         <div class="modal-content center-align">
             <div class="row">
                 <div class="col s12">
                     <ul class="tabs" id="iconTabs">
-                        <li class="tab col s6"><a class="text-blue valign-wrapper <#if hasBuiltinIcon == false>active</#if>" href="#tabImages" data-name="images"><i class="fas fa-image"></i> ${locale.getString(("icons.images"))}</a></li>
-                        <li class="tab col s6"><a class="text-blue valign-wrapper <#if hasBuiltinIcon>active</#if>" href="#tabBuiltinIcons" data-name="builtinIcons"><i class="fas fa-icons"></i> ${locale.getString(("icons.builtin"))}</a></li>
+                        <li class="tab col s6"><a class="text-blue valign-wrapper <#if hasImageIcon>active</#if>" href="#tabImages" data-name="images"><i class="fas fa-image"></i> ${locale.getString(("icons.images"))}</a></li>
+                        <li class="tab col s6"><a class="text-blue valign-wrapper <#if hasImageIcon == false>active</#if>" href="#tabBuiltinIcons" data-name="builtinIcons"><i class="fas fa-icons"></i> ${locale.getString(("icons.builtin"))}</a></li>
                     </ul>
                 </div>
                 <div id="tabImages" class="col s12"><@tabImages item/></div>